Prysm

#1

fix(tests): Correct misleading variable names and expressions in test files by syjn99 · Pull Request #14292 · prysmaticlabs/prysm

What type of PR is this? Other What does this PR do? Why is it needed? Fixed some misleading names and expressions in test files Which issues(s) does this PR fix? N/A Other notes for review This do…

GitHubprysmaticlabs

• Fixed test files that has some misleading lines.

• e.g. in beacon-chain/rpc/prysm/v1alpha1/beacon/validators_test.go, there is a wrong assertion for length of the validator list.
• My first contribution to Prysm! 😄
• Opened at August 2nd, Merged at August 3rd.

#2

fix(tests): Fix v1alpha1/node/server_test.go by syjn99 · Pull Request #14321 · prysmaticlabs/prysm

What type of PR is this? Bug fix What does this PR do? Why is it needed? TestNodeServer_GetPeer often failed, because the first element of peer list is not guaranteed to be same with what MockPeers…

GitHubprysmaticlabs

• Fixed flaky tests in beacon-chain/p2p/testing/mock_peersprovider.go
  • Since iterating a map in Go is not guaranteed to be always same(see StackOverflow), tests are randomly failed.
• Opened at August 8th, Merged at August 13th.

#3

docs: Add `consolidation_requests_root` on comment by syjn99 · Pull Request #14335 · prysmaticlabs/prysm

What type of PR is this? Documentation What does this PR do? Why is it needed? Add consolidation_requests_root initialization on comment. Which issues(s) does this PR fix? Other notes for review

GitHubprysmaticlabs

• Added a line of comment to be consistent with the actual implementation. (One line fix 😂)
• Opened at August 13th, Merged at August 17th.

#4

fix: update p2p `metaData` file when it is changed by syjn99 · Pull Request #14401 · prysmaticlabs/prysm

What type of PR is this? Bug fix What does this PR do? Why is it needed? This PR addresses Issue #13586, where the beacon-chain does not update the metaData file as expected. The issue arises becau…

GitHubprysmaticlabs

• An issue(#13586) raised: p2p metaData file "never" updated after initialization. This matters to the users who provide --p2p-static-id flag. This flag is used to anchor their ID in the p2p network.
• Referring to the consensus-specs, MetaData consists of two fields:

(
  seq_number: uint64
  attnets: Bitvector[ATTESTATION_SUBNET_COUNT]
)

• NOTE: There is an additional field in post-altair(syncnets).
• seq_number is used especailly when a node pings to its peers. If another node received a ping message with lower sequence number than it has, that node rejects this ping message.
  • NOTE: Each node maintains its own peer table, and the sequence number is also maintained in the table.
• However, in the current implementation of Prysm, the sequence number is never updated: it means it remains 0 in the whole lifecycle. This can cause a significant issue with respect to p2p.
• Opened at August 30th, Not yet merged.
  • Seems like they are refactoring p2p package.

EIPs

#1

Update EIP-7732: fix typos by syjn99 · Pull Request #8794 · ethereum/EIPs

fixed typo in EIP-7732.

GitHubethereum

• I was investigating ePBS by reading EIP(link), found some typos.
• Folks often wrongly type withdrawal to widthdrawal. (I did often too lol)